Browse Source

Fixes for dynamic modal a11y (#2116)

* Add modal-dismiss, remove tabindex from modals

* Remove modal-dismiss styles

* Update jslib

* remove cdkTrapFocus etc
remove-specific-keyboard-shortcut-logic
Thomas Rittson 1 month ago
committed by GitHub
parent
commit
5f9541b1cf
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      jslib
  2. 2
      src/popup/components/password-reprompt.component.html
  3. 4
      src/popup/components/set-pin.component.html

2
jslib

@ -1 +1 @@
Subproject commit f09fb69882525b3be7b2e257e7723eeb79b343d1
Subproject commit 24fe836032354d4ec39435776e54dd0995e1b389

2
src/popup/components/password-reprompt.component.html

@ -1,4 +1,4 @@
<div class="modal fade" tabindex="-1" role="dialog" aria-modal="true">
<div class="modal fade" role="dialog" aria-modal="true">
<div class="modal-dialog modal-dialog-scrollable" role="document">
<form class="modal-content" #form (ngSubmit)="submit()">
<div class="modal-body">

4
src/popup/components/set-pin.component.html

@ -1,4 +1,4 @@
<div class="modal fade" tabindex="-1" role="dialog" aria-modal="true" cdkTrapFocus cdkTrapFocusAutoCapture>
<div class="modal fade" role="dialog" aria-modal="true">
<div class="modal-dialog modal-dialog-scrollable" role="document">
<form class="modal-content" #form (ngSubmit)="submit()">
<div class="modal-body">
@ -11,7 +11,7 @@
<div class="row-main">
<label for="pin">{{'pin' | i18n}}</label>
<input id="pin" type="{{showPin ? 'text' : 'password'}}" name="Pin"
class="monospaced" [(ngModel)]="pin" required appInputVerbatim cdkFocusInitial>
class="monospaced" [(ngModel)]="pin" required appInputVerbatim>
</div>
<div class="action-buttons">
<button type="button" class="row-btn" appStopClick appBlurClick appA11yTitle="{{'toggleVisibility' | i18n}}"

Loading…
Cancel
Save